Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/designer actions #1954

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Conversation

breiler
Copy link
Collaborator

@breiler breiler commented Aug 9, 2022

Added an actions map in the controller to prevent duplicate actions to be created and registered as listeners causing memory leaks.

@codecov-commenter
Copy link

Codecov Report

Merging #1954 (d04e565) into master (a23af38) will decrease coverage by 0.01%.
The diff coverage is 1.96%.

@@             Coverage Diff              @@
##             master    #1954      +/-   ##
============================================
- Coverage     22.67%   22.65%   -0.02%     
  Complexity     1997     1997              
============================================
  Files           576      576              
  Lines         24058    24079      +21     
  Branches       1918     1918              
============================================
  Hits           5456     5456              
- Misses        18132    18153      +21     
  Partials        470      470              
Impacted Files Coverage Δ
.../com/willwinder/ugs/nbp/designer/gui/MainMenu.java 0.00% <0.00%> (ø)
...lwinder/ugs/nbp/designer/gui/PopupMenuFactory.java 0.00% <0.00%> (ø)
.../willwinder/ugs/nbp/designer/logic/Controller.java 0.00% <0.00%> (ø)
...gs/nbp/designer/platform/DesignerTopComponent.java 0.00% <0.00%> (ø)
...inder/ugs/nbp/designer/platform/PlatformUtils.java 0.00% <0.00%> (ø)
...illwinder/universalgcodesender/utils/Settings.java 46.94% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@breiler breiler merged commit b5348cd into winder:master Aug 9, 2022
@breiler breiler deleted the bugfix/designer_actions branch January 23, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants