Added listeners to commands to listen for when it completes. #1809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on a new controller implementation and found a need for listening to if a command was completed.
This could be done using a
UGSEventListener
and listening for a CommandEvent in the application, but not from the controller. From the controller we have access to theControllerLisener
but would require to implement a rather large listener interface.I propose to add a listener to the GcodeCommand, this would it make it possible to execute a command and wait for it to be completed: