Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default controller settings for g2core #1784

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

breiler
Copy link
Collaborator

@breiler breiler commented Jan 23, 2022

Made g2core command length longer and disabled it by default. Also made the options dialog activate the selected controller in the settings by default.

Addresses the issue #1577

…de the options dialog activate the selected controller in the settings by default.
@codecov-commenter
Copy link

Codecov Report

Merging #1784 (5c2dcac) into master (d0c926f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1784      +/-   ##
============================================
- Coverage     18.86%   18.86%   -0.01%     
  Complexity     1892     1892              
============================================
  Files           671      671              
  Lines         28141    28145       +4     
  Branches       2304     2304              
============================================
  Hits           5309     5309              
- Misses        22383    22387       +4     
  Partials        449      449              
Impacted Files Coverage Δ
...ments/panels/ControllerProcessorSettingsPanel.java 0.00% <0.00%> (ø)
...gs/nbp/core/options/ControllerPanelController.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c926f...5c2dcac. Read the comment docs.

@breiler breiler merged commit ca41216 into winder:master Jan 23, 2022
@breiler breiler deleted the default-controller-options branch January 23, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants