Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main menu node list sort by node ID #32

Merged
merged 1 commit into from
Jan 6, 2014
Merged

Conversation

jbonicioli
Copy link
Contributor

The all mighty sort by node id main menu fix...

sque added a commit that referenced this pull request Jan 6, 2014
Main menu node list sort by node ID
@sque sque merged commit c744943 into wind-project:master Jan 6, 2014
@sque
Copy link
Member

sque commented Jan 6, 2014

Goustarw na vlepw tetoia commits vradiatika! :D

@ysamouhos
Copy link
Member

This should be a configuration option and not a static sort by node-id hardcode.

@sque
Copy link
Member

sque commented Jan 7, 2014

I think the stated problem (at awmn forum) was the determinism of nodes position. It could be with the ID or the Name, for me eitherway it solves it properly.

@ysamouhos
Copy link
Member

You should be able to configure it either user side (drop down list with choices) or admin side default sort.

Remember this is not AWMN specific build.

@jbonicioli
Copy link
Contributor Author

This comment and solution can be expanded to all list menus. A sort by something when you click on a header needs to be implemented.
Potentially if someone wanted to be tatty he could expand this small bag fix for all arbitrary sorted lists in the application. But I didn't. Further to this, all those sort list functions have taken 9 years to emerge, so I am not very optimistic as to when we are going to see them. I think we/I will try but there is so much to fix. So I did a quick fix on the most important list that has been requested by so many. It makes sense since it hurts one's eyes to find a reason, and a node for the fact, in the list of his personal nodes. Leave this one and fix it when we have a total solution.

@sque
Copy link
Member

sque commented Jan 7, 2014

If you have any big plan for WiND 1, forget it... The code does not permit this kind of changes. Every commit is a PITA and almost no reason. V1.1 is just a pillow release with some long standing features and some polishing so that users can gain fate on the project and w8 for WiND 2.

In WiND 2 all these will be defacto features provided by the framework.

@jbonicioli
Copy link
Contributor Author

Agreed

@ysamouhos
Copy link
Member

Keep notes on these "Defacto" features.
The fact that all these "features" have taken 9 years to emerge is the one that makes me think twice when it comes to "features". Not to be pessimistic but I don't see any active developers for Wind v2 and even if there where more than 3-4 if we can call us developers, how much time do you think an alpha v2 version will take to build from scratch?

I am looking at the "reality" side of things if I may be excused :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants