Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on Sparse API. #98

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Improvements on Sparse API. #98

merged 4 commits into from
Aug 29, 2024

Conversation

AndPotap
Copy link
Collaborator

@AndPotap AndPotap commented Aug 28, 2024

Now the sparse API requires row_indices, col_indices and data which makes it easier for the user to construct the Sparse operator. This is the COO "ijv" format. Since this format is not the most efficient for matrix-multiplication, it is then internally transformed to the CSR format which is what the API was asking the user before.

@AndPotap AndPotap merged commit 50dd4cc into main Aug 29, 2024
6 checks passed
@AndPotap AndPotap deleted the sparse_improvements branch August 29, 2024 22:27
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (d9e12c0) to head (19a88e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   83.13%   83.33%   +0.19%     
==========================================
  Files          41       41              
  Lines        3516     3534      +18     
==========================================
+ Hits         2923     2945      +22     
+ Misses        593      589       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant