In convert_date(), round the seconds values for more accuracy #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, many thanks for creating this package @willtrnr . It's greatly appreciated.
This PR should address an issue I found when converting datetime values from the floats in an .xlsb spreadsheet. The date in question was July 4 2020 at 10:00:00. In Excel, this is stored as the floating point number 44016.416666666664. However, when
convert_date()
is used to retrieve the datetime, something unexpected happened:In
convert_seconds()
the seconds values are cast to integers withint
. This truncates the seconds, whereasround
will I believe return a better, more correct value:Hence, this PR changes the
int
toround
so the nearest seconds value is returned, not the lower one.