-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support removing empty values in ListOf #268
Comments
I think we have a couple of options. We could have
Or we could have the sub-parser be in charge of whether the item is valid:
I think I may do the latter. That would be usable in other places, too. |
Scratch that. If we do the former, we can get a better error message because |
This adds empty value validation to ListOf.
This adds empty value validation to ListOf.
This adds empty value validation to ListOf.
ListOf
takes a sub parser and an optionaldelimiter
argument denoting what the delimiter for the items in the value should be.That gives us things like this:
The problem is the empty strings which require the developer to add additional value validation/adjustments. Notably, if they don't want to support empty values (it's likely a typo), they have to do something like this:
I think we want to allow the developer to denote that empty strings are a configuration error.
The text was updated successfully, but these errors were encountered: