Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement multiple drilldownform #8

Closed

Conversation

willie-hung
Copy link
Owner

Description

Implemented multiple drilldown form.

Problem in this PR

The canvas couldn't render correctly according to the editor.

Demo

multiple_drilldown_form.mov

Testing the changes

No testing.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@willie-hung willie-hung changed the title [Feature] Implemented multiple drilldownform [Feature] Implement multiple drilldownform Nov 29, 2023
@willie-hung
Copy link
Owner Author

It seems like there is a type inconsistency in ast.js and get_type.js that leads to the canvas rendering error.

Screenshot 2023-11-29 at 4 07 13 PM

@willie-hung willie-hung changed the base branch from feature/drilldown to feature/mock-drilldown November 29, 2023 22:40
@willie-hung willie-hung deleted the feature/multiple-drilldownform branch November 30, 2023 00:58
willie-hung pushed a commit that referenced this pull request Sep 14, 2024
…t#6105)

* Import sample data to workspace

Signed-off-by: Lin Wang <[email protected]>

* Enable workspace ui plugin

Signed-off-by: Lin Wang <[email protected]>

* Add changelog for import sample data to current workspace

Signed-off-by: Lin Wang <[email protected]>

* feat: register sample data as standalone app (#8)

* feat: register sample data as standalone app

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use props to pass homeLink

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>

* Retrieve workspace id from request

Signed-off-by: Lin Wang <[email protected]>

* Remove workspace id in query

Signed-off-by: Lin Wang <[email protected]>

* Move changelog to fragments

Signed-off-by: Lin Wang <[email protected]>

* Fix sample data list unit tests

Signed-off-by: Lin Wang <[email protected]>

* Remove no need workspaces deps

Signed-off-by: Lin Wang <[email protected]>

* Remove manual created changelogs

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR opensearch-project#6105 created/updated

* Enable sample data in workspace overview page (#9)

* enable sample data in workspace overview page

Signed-off-by: Hailong Cui <[email protected]>

* add comments for empty id

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* Add unit tests for getFinalSavedObjects in data sets util file

Signed-off-by: Lin Wang <[email protected]>

* Add unit tests for renderImportSampleDataApp destroy

Signed-off-by: Lin Wang <[email protected]>

* Address PR comments

Signed-off-by: Lin Wang <[email protected]>

* Remove history listen in renderImportSampleDataApp

Signed-off-by: Lin Wang <[email protected]>

* Remove Route for workspace import sample data entry point

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Hailong Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant