Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy-chart] consider deltaX in findClosestDatums, fix tickLabelProps bug in <*Axis /> #82

Merged
merged 1 commit into from
Dec 8, 2017

Conversation

williaster
Copy link
Owner

This PR does the following

🐛 Bug Fix

  • Fixes a bug where tickLabelProps is not used when passed in either <XAxis /> or <YAxis />. This prop enables per-tick styles so is importanté!

  • Improves the logic for finding closest datums across series when eventTrigger=container by considering deltaX from mouseX in addition to deltaY from mouseY. If deltaX is not considered, the "closest" datum in the y dimension might belong to a series whose nearest x value is quite far from mouseX (if the other data points are null, for instance):

Before

After

@coveralls
Copy link

coveralls commented Dec 8, 2017

Coverage Status

Coverage increased (+0.04%) to 84.457% when pulling 3a594de on chris--bugz into 2a72bc7 on master.

@williaster williaster merged commit a2eae66 into master Dec 8, 2017
@williaster williaster deleted the chris--bugz branch December 8, 2017 02:20
@williaster williaster added this to the v0.0.50 milestone Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants