Read Slice(UInt8) as String if given as type

[matthewmcgarvey]

Fixes #43

In order to support the citext extension in Avram, we need to be able to treat the column as a String. Two solutions were laid out in the connected issue:

• A: Calling rs.read(String) on a string-like column (citext, enum or similar), it should return a String.
• B: Calling rs.read on a string-like column, it should probably also return a String.

B was considered the more "complete solution" but also the more complicated. Since it's been 4 years since the issue was opened and over a year since the potential solutions were laid out, I went with the more immediate option A. If the read type is Slice(UInt8), which is the type of a citext column, and #read was called with a type of String, then convert it to String. This helps with citext interop and I'm sure it helps with other column types as well.

[matthewmcgarvey]

This is related to #89 which is attempting a more complete implementation laid out here #43 (comment) but stalled out.

[will]

Thanks! This looks good to me. I don’t myself use citext though, so I'm going to leave this open for a couple of days in case anyone has comments. But I expect to merge this, then do a release sometime early next week.

[bcardiff]

At some point conversions like this should be handled in crystal-db directly as long as they are type-safe and without configuration. But to this some changes in the design need to be made. So, this is they for now.

[bcardiff]

Oh! I remember. Double check that when using rs.read(String?) the conversion will work. It will probably wont. In crystal-sqlite3 there are a couple of these IIRC.

[will]

Thanks!