Credential indexer #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y re-hashing as credential
… projection mapper
Credential indexer prototype
…additiona describe
also correctly set 'poolSize' when initializing Typeorm DataSource and add some unit tests for TypeormService
BREAKING CHANGE: remove updateWitness method from observable wallet - add addSignatures method to observable wallet
- @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected] - @cardano-sdk/[email protected]
…ss slots with constraints
mkazlauskas
reviewed
Aug 20, 2024
|
|
||
| more = (b & 128) !== 0; | ||
| ++bytesRead; | ||
| } | ||
|
|
||
| return { bytesRead, value }; | ||
| return { bytesRead, value: value <= Number.MAX_SAFE_INTEGER ? Number(value) : Number.POSITIVE_INFINITY }; |
There was a problem hiding this comment.
We should add a test for round-tripping a Pointer address that uses a slot>MAX_SAFE_INTEGER. In order for that to work, we'll need to change this Pointer type to store a bigint, and save the full value when packing in order to reuse when unpacking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Reason for the change? If an issue exists, reference it here using a keyword
Proposed Solution
Important Changes Introduced