Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blog post: Introduction to the various Java based Kubernetes/Open… #458

Merged
merged 1 commit into from
Nov 30, 2023
Merged

add blog post: Introduction to the various Java based Kubernetes/Open… #458

merged 1 commit into from
Nov 30, 2023

Conversation

liweinan
Copy link
Contributor

…Shift tools and

their usages in WildFly related projects

@liweinan liweinan marked this pull request as draft September 19, 2023 18:38
@liweinan
Copy link
Contributor Author

@kabir @jamezp @jimma @asoldano Could you please help to check this blog post when you have time? If there are anything incorrect or missing I'll fix it :D

@liweinan
Copy link
Contributor Author

rendered text: https://github.com/wildfly/wildfly.org/blob/388b9f605fb3026c2455e9bc7fad78c0fb85459a/_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc

@liweinan liweinan self-assigned this Sep 26, 2023
jamezp
jamezp requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is good. However, I think we need to drive this as a WildFly based blog post.

_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc

[source,java]
----
private void startResourcesInList(ExtensionContext context, KubernetesResource kubernetesResource, KubernetesList resourceList) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful about showing these methods IMO. They could change, but it's okay to express the idea if that is the goal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added note to the code in above:

(please note these internal implementations may change in the future, and it's shown here just for expressing the idea)

@liweinan
Copy link
Contributor Author

Thanks for the review @jamezp @jimma ! I'll check the details and do the modifications accordingly :D

@liweinan
Copy link
Contributor Author

@jamezp I have fixed most parts as review opinions, and I have some questions left in the comments. Could you please help to check this when you have time? Thanks!

@liweinan
Copy link
Contributor Author

I'll add a section describing the usage of wildfly-maven-plugin which can generate Dockerfile and provision WildFly.

jamezp
jamezp requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks okay. I think we should remove the references to the "JAX-RS" support in the Dekorate annotation processing. That code will not work with any current version of WildFly.

The date in the path and in the header needs to be updated too before this could be merged.

_posts/2023-09-20-intro-to-the-various-java-based-k8s-oc-tools.adoc Outdated Show resolved Hide resolved
@liweinan
Copy link
Contributor Author

Overall I think this looks okay. I think we should remove the references to the "JAX-RS" support in the Dekorate annotation processing. That code will not work with any current version of WildFly.

The date in the path and in the header needs to be updated too before this could be merged.

Yes sir!

@liweinan
Copy link
Contributor Author

I'll add the wildfly-maven-plugin section and (maybe) finalize the content this week :D

@liweinan liweinan marked this pull request as ready for review November 14, 2023 15:23
@liweinan liweinan force-pushed the k8s-tools-intro branch 2 times, most recently from ac2a32a to 14012a6 Compare November 14, 2023 15:33
@liweinan
Copy link
Contributor Author

@jamezp I have finished updating the article, could you please help to review it again? Thanks!

@jamezp
Copy link
Member

jamezp commented Nov 29, 2023

LGTM @liweinan. We'll once again just need a date update.

@liweinan
Copy link
Contributor Author

LGTM @liweinan. We'll once again just need a date update.

Yes sir!

@liweinan
add blog post: Introduction to the various Java based Kubernetes/Open…
70b489c 
…Shift tools and their usages in WildFly related projects.
@liweinan
Copy link
Contributor Author

@jamezp Done!

@jamezp jamezp merged commit 144c3a4 into wildfly:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

@jimma jimma jimma approved these changes

Assignees

@liweinan liweinan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liweinan @jamezp @jimma