[Issue_166] Add the ability to exclude Faces new TCK tests; exclude challenge #1935 tests #168
Conversation
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <configuration> | ||
| <excludesFile>${se21.newtck.exclusions}</excludesFile> |
There was a problem hiding this comment.
Note I went with an excludesFile element here instead of an excludes element because it's not clear from the failsafe documentation whether method filtering is supported for 'excludes'. It's only documented in the excludesFile row:
Since 3.0.0-M6, method filtering support is provided in the exclusions file as well, example:
If it turns out it works with 'excludes' as well (which seems reasonable) in a future improvement we can perhaps switch to that and remove a couple files.
There was a problem hiding this comment.
A file seems fine as it can be updated in a more clear manor IMO.
| # Challenge https://github.com/jakartaee/faces/issues/1935 | ||
| **/ee/jakarta/tck/faces/test/javaee8/converter/Issue4070IT#testJavaTimeTypes | ||
| **/ee/jakarta/tck/faces/test/javaee8/converter/Issue4087IT#testJavaTimeTypes | ||
| **/ee/jakarta/tck/faces/test/javaee8/converter/Issue4110IT#testJavaTimeTypes |
There was a problem hiding this comment.
This file is cruft; I'll delete it.
| @@ -13,6 +13,8 @@ | |||
| //*[local-name()='profiles']"> | |||
| <xsl:copy> | |||
| <xsl:apply-templates select="document('profile.xml')/*"/> | |||
| <xsl:apply-templates select="document('global-excludes-profile.xml')/*"/> | |||
| <xsl:apply-templates select="document('se21-excludes-profile.xml')/*"/> | |||
There was a problem hiding this comment.
Note: I tried to include 3 'profile' elements in profile.xml and it didn't work. When my time budget for renewing my xslt skills was used up I went with 3 separate files.
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <configuration> | ||
| <excludesFile>${se21.newtck.exclusions}</excludesFile> |
There was a problem hiding this comment.
A file seems fine as it can be updated in a more clear manor IMO.
…hallenge #1935 tests
|
I just updated this to remove the cruft file. |
|
Thanks @bstansberry for making this change! |
|
Thanks @jamezp @jasondlee and @scottmarlow |
Resolves #166
Also changes the default Faces TCK version to the current 4.0.3.