Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19846] Migrate MP Tel 2.0 from PREVIEW to DEFAULT #624

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jasondlee
Copy link
Contributor

@jasondlee jasondlee commented Oct 14, 2024

Add analysis document

Resolves #619

@github-actions github-actions bot added the stability-level/default "Default" stability-level label Oct 14, 2024
@jasondlee jasondlee requested a review from rhusar October 15, 2024 18:48
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 15, 2024
@jasondlee jasondlee marked this pull request as ready for review October 15, 2024 20:31
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 18, 2024
@jasondlee jasondlee requested a review from jamezp October 18, 2024 17:50
@marekkopecky
Copy link

@jasondlee Thank you for this analysis! I left a few comments here and there, I would appreciate if you can provide some feedback on them.

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 4, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 4, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 4, 2024
@marekkopecky
Copy link

Can you please elaborate why it's useful to keep micrometer basic metrics, micrometer metrics and telemetry metrics? Could all these metrics in server be confusing for users?

@jasondlee
Copy link
Contributor Author

jasondlee commented Nov 7, 2024

Can you please elaborate why it's useful to keep micrometer basic metrics, micrometer metrics and telemetry metrics? Could all these metrics in server be confusing for users?

Potentially, yes, but both libraries have been offered for some time before they began overlapping in functionality as they do now. There are (slow-moving) discussions on how to handle that, but, for now, the decision is to offer both and allow the users to choose.

@marekkopecky
Copy link

@jasondlee Thank you for your feedback! Is there some need for users to migrate from MicroMeter metrics to MP Telemetry Metrics? I can imagine that some users prefers to use MP components, so this kind of migration can be useful for them. WDYT?

I'm also thinking about general migration. My understanding is that if users are using micrometer, they need to disable WF Metrics first according to the 7.16.1 chapter of WF admin guide. Now, the metrics are also provided by telemetry. So if users want to use micrometer now, they need to disable MP telemetry metrics, right? If yes, this affects migration from previous WF versions to latest WF version and needs to be elaborate in the analysis document itself.

@marekkopecky
Copy link

What is the plan about default behaviour? Are both WF metrics and MP Telemetry Metrics enabled by default?

@jasondlee
Copy link
Contributor Author

So if users want to use micrometer now, they need to disable MP telemetry metrics, right? If yes, this affects migration from previous WF versions to latest WF version and needs to be elaborate in the analysis document itself.

Yes. I've added some language to the AD to have this addressed in the community docs.

@jasondlee
Copy link
Contributor Author

What is the plan about default behaviour? Are both WF metrics and MP Telemetry Metrics enabled by default?

Yes, if the admin starts with server using any of the MicroProfile configurations. See note above about updating the community docs.

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 11, 2024
@jasondlee
Copy link
Contributor Author

@marekkopecky I can't seem to add you to the wildfly PR, so here's a link to the docs update: wildfly/wildfly#18357

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 20, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 21, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 22, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Nov 26, 2024
@bstansberry bstansberry merged commit f5e9643 into wildfly:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability-level/default "Default" stability-level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MP Platform 7] MicroProfile Telemetry 2.0
7 participants