-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-19846] Migrate MP Tel 2.0 from PREVIEW to DEFAULT #624
Conversation
@jasondlee Thank you for this analysis! I left a few comments here and there, I would appreciate if you can provide some feedback on them. |
Can you please elaborate why it's useful to keep micrometer basic metrics, micrometer metrics and telemetry metrics? Could all these metrics in server be confusing for users? |
Potentially, yes, but both libraries have been offered for some time before they began overlapping in functionality as they do now. There are (slow-moving) discussions on how to handle that, but, for now, the decision is to offer both and allow the users to choose. |
@jasondlee Thank you for your feedback! Is there some need for users to migrate from MicroMeter metrics to MP Telemetry Metrics? I can imagine that some users prefers to use MP components, so this kind of migration can be useful for them. WDYT? I'm also thinking about general migration. My understanding is that if users are using micrometer, they need to disable WF Metrics first according to the 7.16.1 chapter of WF admin guide. Now, the metrics are also provided by telemetry. So if users want to use micrometer now, they need to disable MP telemetry metrics, right? If yes, this affects migration from previous WF versions to latest WF version and needs to be elaborate in the analysis document itself. |
What is the plan about default behaviour? Are both WF metrics and MP Telemetry Metrics enabled by default? |
Yes. I've added some language to the AD to have this addressed in the community docs. |
Yes, if the admin starts with server using any of the MicroProfile configurations. See note above about updating the community docs. |
645154b
to
80d7704
Compare
@marekkopecky I can't seem to add you to the |
80d7704
to
93ef703
Compare
93ef703
to
e87648e
Compare
e87648e
to
d3bfa0f
Compare
d3bfa0f
to
3427a3e
Compare
Add analysis document
Resolves #619