Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-19588] Proposal for MicroProfile Platform 7.0 #616

Merged
merged 9 commits into from
Dec 13, 2024
Merged

[WFLY-19588] Proposal for MicroProfile Platform 7.0 #616

merged 9 commits into from
Dec 13, 2024

Conversation

kabir
Copy link
Contributor

@kabir kabir commented Oct 9, 2024

@kabir kabir force-pushed the mp-platform-7-WFLY-19588 branch from b22fe33 to cde38d7 Compare October 11, 2024 15:01
@kabir kabir mentioned this pull request Oct 14, 2024
Closed
@kabir kabir force-pushed the mp-platform-7-WFLY-19588 branch from cde38d7 to 48a3826 Compare October 14, 2024 14:50
@github-actions github-actions bot added the stability-level/default "Default" stability-level label Oct 14, 2024
fabiobrz
fabiobrz suggested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kabir - thanks for your proposal. I finally had the chance to go through it 🙂
I've dropped some comments and questions, and asked for some changes.
Feel free to let me know what you think.

microprofile/WFLY-19588_microprofile_platform_7.adoc Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated
* https://issues.redhat.com/browse/WFLY-19592[WFLY-19592 - MicroProfile Fault Tolerance 4.1]
* https://issues.redhat.com/browse/WFLY-19591[WFLY-19591 - MicroProfile OpenAPI 4.0]
* https://issues.redhat.com/browse/WFLY-19589[WFLY-19589 - MicroProfile REST Client 4.0]
* https://issues.redhat.com/browse/WFLY-19589[WFLY-19589 - MicroProfile Telemetry 2.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. This doesn't look right, as it is the same tracker as the MP REST Client upgrade. It should be https://issues.redhat.com/browse/WFLY-19846 and also https://issues.redhat.com/browse/WFLY-19590.

microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Show resolved Hide resolved
microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated
* Where one of the specifications being upgraded needs additional testing beyond what is done by the TCK, it should be pointed out in the analysis of the individual specification upgrade.

== Community Documentation
* Community documentation for the subsystems in question will be updated to reflect the new versions, and any potential differences in behaviour.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add that this will be tracked by individual spec upgrade WFLY issues, as you've done in previous sections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some 'common' documentation bit, that just says that "WildFly is MicroProfile 7.0 compliant runtime".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for pointing this out @rhusar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabir do you have any feedback on @rhusar's comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a section, and opened a PR with the changes wildfly/wildfly#18322

microprofile/WFLY-19588_microprofile_platform_7.adoc Outdated
== Release Note Content
MicroProfile specifications have been updated to the versions that are part of MicroProfile Platform 7.0. (See the table in the link:#overview[Overview] if exact versions are needed)

MicroProfile OpenTracing has been removed from the MicroProfile 6 platform, in favour of MicroProfile Telemetry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we know this already? I mean, we removed the integration when we upgraded the specs to 6.1, right? Or am I missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Feel free to resolve.

@kabir kabir force-pushed the mp-platform-7-WFLY-19588 branch from 48a3826 to 31a1733 Compare October 23, 2024 14:34
@kabir kabir force-pushed the mp-platform-7-WFLY-19588 branch from 31a1733 to 89608f0 Compare October 23, 2024 15:31
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 25, 2024
fabiobrz and others added 2 commits October 25, 2024 16:01
@fabiobrz
[WFLY-19588] More fixes (links, requirements structure, default confi…
70ceca9 
…g changes)
@kabir
Merge pull request #3 from fabiobrz/mp-platform-7-WFLY-19588.more-fixes
b63ffc3 
[WFLY-19588] More fixes (links, requirements structure, default config changes)
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 25, 2024
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 25, 2024
@kabir kabir mentioned this pull request Oct 25, 2024
Merged
fabiobrz
fabiobrz approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this proposal @kabir - changes LGTM, approving from QA perspective.

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Oct 28, 2024
@darranl
Copy link
Contributor

darranl commented Dec 6, 2024

@rhusar you previously requested changes, is it possible to change your review to approved or anything outstanding?

rhusar
rhusar approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now (@darranl all feedback has been addressed already)

@darranl darranl merged commit 8aa348e into wildfly:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobrz fabiobrz fabiobrz approved these changes

@rhusar rhusar rhusar approved these changes

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
stability-level/default "Default" stability-level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kabir @darranl @jamezp @rhusar @fabiobrz