Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6960]: Promote Simple config export for a server as an attachment from COMMUNITY to DEFAULT. #594

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[WFCORE-6960]: Promote Simple config export for a server as an attachment from COMMUNITY to DEFAULT. #594

merged 1 commit into from
Sep 19, 2024

Conversation

ehsavoie
Copy link
Contributor

@ehsavoie ehsavoie mentioned this pull request Aug 28, 2024
Merged
fabiobrz
fabiobrz suggested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this proposal @ehsavoie - I dropped some comments, feel free to let me know what you think.

...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Outdated Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Outdated Show resolved Hide resolved
@ehsavoie ehsavoie force-pushed the WFCORE-6960 branch 3 times, most recently from 03cbd7d to 76ea71a Compare August 29, 2024 13:32
fabiobrz
fabiobrz suggested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my remarks @ehsavoie - I've left a couple more comments.

fabiobrz
fabiobrz suggested changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 2 minor typos...

...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Outdated Show resolved Hide resolved
...E-6960_Simple_config_export_for_a_server_as_an_attachment_for_standalone_or_domain_mode.adoc Outdated Show resolved Hide resolved
@ehsavoie ehsavoie force-pushed the WFCORE-6960 branch 3 times, most recently from 5ae3b59 to 2b3254c Compare September 2, 2024 08:18
fabiobrz
fabiobrz approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ehsavoie for your work on this proposal. Changes LGTM, approving.

@emmartins
Copy link
Contributor

Hi @ehsavoie , can you please add the information wrt the following sections:

*Backwards Compatibility
**Default Configuration
**Importing Existing Configuration
*Deployments

Even if empty, those sections are now used by Migration Feature team to figure out which feature teams are doing migration related changes, so we may help them.

@ehsavoie
Copy link
Contributor Author

@emmartins all should be addressed

@yersan yersan merged commit 544fedf into wildfly:main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobrz fabiobrz fabiobrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehsavoie @emmartins @fabiobrz @yersan