Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19130] Publish Wildfly channels #561

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Mar 20, 2024

@spyrkob spyrkob force-pushed the WFLY-19130 branch 2 times, most recently from f4d0316 to 6868a2c Compare March 20, 2024 14:30
|wildfly-ee-galleon-pack and its dependencies
| -

|`org.wildfly.channels:wildfly`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if a better name would be something like org.wildfly.channels:wildfly-full

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a bummer.

If you to provision what almost everyone regards as WildFly you use the 'wildfly' feature pack. Adding "full" is confusing.

The channels are a bit different from the feature packs though; using the 'wildfly' FP means you unavoidably get 'wildfly-ee' with no need for the user to even be aware that's happened.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly for consistency - the other two channels have a name of wildfly-*, so it feels like channel name wildfly misses something :)
On the other hand, like you said, wildfly is consistent with naming of the feature packs.

@spyrkob
Copy link
Contributor Author

spyrkob commented Mar 27, 2024

@bstansberry do we want to think about adding the provisioning metadata to the WildFly zip we distribute? Adding .galleon/provisioning.xml, .installation/installer-channels.yaml and .installation/manifest.yaml would make it ready to be used with Prospero to e.g. install new feature-packs

@bstansberry
Copy link
Contributor

@spyrkob I've approved this as I think it's fine for WF 32 Beta.

Re adding more metadata to the standard zips, what would that require in terms of build process? We provide a .galleon/provisioning.xml, but just an empty .installation dir. Adding more makes sense and is something we can add into this analysis for 32 Final, if the mechanics involved in producing it work out.

@darranl
Copy link
Contributor

darranl commented Apr 2, 2024

@jamezp As a member of the feature team are you able to review / approve this one please?

@darranl darranl requested a review from jamezp April 2, 2024 17:22
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. I approved the WildFly PR and forgot about this one. :)

@darranl darranl merged commit 9b6a3dd into wildfly:main Apr 3, 2024
@spyrkob spyrkob deleted the WFLY-19130 branch April 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants