-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-18185] Provide a possibility for a caching realm to authenticate users with underlying realm when credential verification with cached credential fails #530
Conversation
36e3119
to
983b7dd
Compare
|
||
=== Affected Projects or Components | ||
|
||
* https://github.com/wildfly/wildfly-core[WildFly Core project] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WF Core seems not affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
== Release Note Content | ||
|
||
It is now possible to use the new credentials to authenticate to the WildFly server if these credentials have been configured outside of WildFly in the user store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now possible to use the new credentials to authenticate ...
I miss the part about cached credentials. What about something like the following?
It is now possible to update cached credentials with new credentials and authenticate ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OndrejKotek Thank you. fixed
|
||
=== QE Contacts | ||
|
||
* mailto:TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be added now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment to understand if this is configurable or just now the new behaviour.
|
||
== Release Note Content | ||
|
||
It is now possible to update cached credentials with new credentials and authenticate to the WildFly server if those credentials have been updated outside of WildFly in the user store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mention "it is now possible" but if this is now the default behaviour it should probably be stated as that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
||
This functionality should either be added as a default, as this was the behaviour of the legacy security subsystem. Or we can add this behaviour under a new attribute of the caching realm. If we add it as configurable with a property, then it can be backported with a system property. | ||
|
||
I have decided to enable this functionality by default. The reason for this is that this functionality was present in the legacy security, and users can consider the absence of this functionality to be a bug, so we should not require its configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mention enable by default but it does not look now like there will be a mechanism to turn it off? May be worth stating it is not optional if that is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be possible to change this. I updated the doc
@Skyllarr Please add a section like the one here: and X one of the boxes. If it's 'Preview' please change the JIRA title and proposal title to 'Preview - Provide a...'. Given the discussions at https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/Questions.20about.20the.20the.20new.20stability.20development.20process about the configuration style, and some of the conversation's I've seen with @pferraro about clustering, if this is wanted for WF 31, 'Preview' level may be the best choice. |
@bstansberry We have decided to not target wildfly 31 for this. I will add this new section and I'll mention the |
…e users with underlying realm when credential verification with cached credential fails
@bstansberry This can be merged now, as the feature implementation was already merged |
https://issues.redhat.com/browse/WFLY-18185