[WFLY-17510] Convert MicroProfile OpenTracing subsystem to Admin-Only Mode #512
Conversation
jasondlee
changed the title
There was a problem hiding this comment.
Thanks for this proposal @jasondlee!
Just a few minor comments, let me know what you think.
|
|
||
| === Default Configuration | ||
|
|
||
| The default configuration for MicroProfile configurations will be altered to remove the MicroProfile OpenTracing subsystem. Likewise, the relevant Galleon layers will also have the extension removed from their definitions. |
There was a problem hiding this comment.
Is it Galleon layers or feature packs? I am not sure though, just asking.
There was a problem hiding this comment.
I think, both actually. There are layer-spec.xml files, as well as feature pack definitions. @bstansberry can chime in if I'm off base here. :)
There was a problem hiding this comment.
It's layers.
The feature pack still incorporates MP OT as a FP incorporates everything that can get provisioned, and MP OT can get provisioned. The galleon content used for the default configs and the layers are what drive whether MP OT shows up in the configuration files. That's what we want to change.
That said, the words "the relevant Galleon layers" should be replaced with an explicit list of the layers that are going to change.
There was a problem hiding this comment.
I'll update that text to include those layers.
There was a problem hiding this comment.
@bstansberry @fabiobrz Edited the text. Is that better?
There was a problem hiding this comment.
Yep, I think it solves Brian's concerns.
Analysis doc for MP OpenTracing Removal
Add layer information to the proposal
jasondlee
requested review from
fabiobrz and
bstansberry
and removed request for
fabiobrz
There was a problem hiding this comment.
Thanks for addressing my comments @jasondlee - the proposal looks good from the QE perspective, approving.
|
Great. Thanks for all the help @fabiobrz! |
https://issues.redhat.com/browse/WFLY-17510
Analysis doc for MP OpenTracing Removal