Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-15260] Support for securing the management console with OIDC #506

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

fjuma
Copy link
Contributor

@fjuma fjuma commented Dec 22, 2022

http://localhost:MANAGEMENT_PORT/elytron-oidc-client/wildfly-console/index.html). HAL will need to be
updated to access this endpoint and if it finds OIDC configuration, HAL would then
redirect to the OIDC provider login page.
* It will be possible to log out of the management console after having logged in with OIDC.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just local logout of the console, or the complete OIDC logout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with the existing support, logging out resulted in the complete OIDC logout. So the idea would be to do the same here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the logout have effect also on an application deployed into EAP secured by OIDC when we are logged in with the same user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this would also affect an application secured by OIDC with the same user.

== Test Plan

Tests will be added to the WildFly testsuite to verify that the management console
can be secured successfully with OIDC.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple tests for the logout and for using RBAC would be also useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this section to mention that, thanks @OndrejKotek!

@fjuma fjuma requested a review from hpehl January 4, 2023 14:44
Copy link
Contributor

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fjuma, for the delay. I missed that this still needs my review.

The RFE looks good to me. No objections from my side.

@kstekovi
Copy link

Looks good also to me.

@darranl darranl merged commit 0b96497 into wildfly:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants