-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EAP7-1457] Allow to mount ConfigMap at arbitrary locations from the operator #300
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yersan, it looks good to me
Added Engineering as Tester, there is no changes in the document content |
|
||
* The specification of the mount path should be optional. | ||
* If a config map does not specify the mount path, the config map will be mounted under `/etc/configmaps/<config map name>` | ||
* Users should be able to specify absolute or relative paths. If it is a relative path, the path will be treated as relative to `JBOSS_HOME`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yersan in Bootbale Jar images there is no JBOSS_HOME
:
sh-4.4$ env | grep JBOSS
JBOSS_IMAGE_NAME=ubi8/openjdk-11
JBOSS_CONTAINER_MAVEN_DEFAULT_MODULE=/opt/jboss/container/maven/default/
JBOSS_CONTAINER_JAVA_RUN_MODULE=/opt/jboss/container/java/run
JBOSS_CONTAINER_MAVEN_36_MODULE=/opt/jboss/container/maven/36/
JBOSS_CONTAINER_S2I_CORE_MODULE=/opt/jboss/container/s2i/core/
JBOSS_CONTAINER_OPENJDK_JDK_MODULE=/opt/jboss/container/openjdk/jdk
JBOSS_CONTAINER_JOLOKIA_MODULE=/opt/jboss/container/jolokia
JBOSS_CONTAINER_JAVA_S2I_MODULE=/opt/jboss/container/java/s2i
JBOSS_CONTAINER_JAVA_JVM_MODULE=/opt/jboss/container/java/jvm
JBOSS_IMAGE_VERSION=1.3
JBOSS_CONTAINER_PROMETHEUS_MODULE=/opt/jboss/container/prometheus
JBOSS_CONTAINER_MAVEN_S2I_MODULE=/opt/jboss/container/maven/s2i
JBOSS_CONTAINER_UTIL_LOGGING_MODULE=/opt/jboss/container/util/logging/
JBOSS_CONTAINER_JAVA_PROXY_MODULE=/opt/jboss/container/java/proxy
hence the mechanism used to run customs script in the $JBOSS_HOME/extensions
folder would not work for bootable jars; it actually broke during the build for me:
...
Running /home/jboss/install.sh
+ echo 'Running /home/jboss/install.sh'
+ injected_dir=/tmp/src/extensions
+ cp -rf /tmp/src/extensions /extensions
cp: cannot create directory '/extensions': Permission denied
error: build error: error building at STEP "RUN /usr/local/s2i/assemble": error while running runtime: exit status 1
that's probably expected since the procedure to run cli
for bootable jars is different: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.3/html/using_eclipse_microprofile_with_jboss_eap_xp_2.0.0/the-bootable-jar_default#cli-scripts_default;
but, since the operator is supposed to work with both bootable and non bootable jar images, mentioning JBOSS_HOME
as default for relative paths, leaves out the bootable jar image case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yersan I’d like to revisit this topic. What will the relative path for images be when using a bootable jar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnovak1 When the Operator deploys a Bootable JAR application image, the image is extracted in a specific directory that acts as a JBOSS_HOME of that image. For the WildFly Operator, this path is /opt/jboss/container/wildfly-bootable-jar-server
. We are in an early stage yet, but I guess additional considerations will need to be done for Bootable JAR images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not already done yet, could you mention /opt/jboss/container/wildfly-bootable-jar-server
to be JBOSS_HOME
in the analyses for bootable jar image, please?
…operator Add Engineering as Tester Update analisys doc
WildFly Operator issue: wildfly/wildfly-operator#135