[WFLY-12779] Incorporate MicroProfile Config in RESTEasy

[ronsigal]

No description provided.

[rsvoboda]

This RFE should be tested also by QE, asking for bump of the rank.

[ronsigal]

Updated

[ronsigal]

1. As I mentioned on WFLY-12779, I would like to re-consider the introduction of parameter "resteasy.config.resteasy.parameters.only", which would restrict the use of RESTEasy's servlet specific ConfigSources to returning only RESTEasy parameters. Thinking about it again, it seems strange to allow MicroProfile Config users to access any parameters using the other ConfigSources and then impose a restriction just on RESTEasy ConfigSources. I would like to dispense with that idea.

2. I have submitted a RESTEasy pull request ([RESTEASY-2406] Port use of Microprofile Config to 3.x resteasy/resteasy#2250) with all of the appropriate changes. It should be merged into RESTEasy 3.10.0.Final (, which should then be upgraded in Wildfly 19 (https://issues.redhat.com/browse/WFLY-12712).

3. [RESTEASY-2406] Port use of Microprofile Config to 3.x resteasy/resteasy#2250 includes several tests (https://github.com/ronsigal/Resteasy/tree/3.10_2406/testsuite/integration-tests/src/test/java/org/jboss/resteasy/test/microprofile/config). These tests verify that configuration information can be retrieved from system variables, servlet context parameters, servlet init parameters, and web.xml filter parameters and that the ConfigSources are accessed in the proper order according to their assigned ordinals.

4. [RESTEASY-2406] Port use of Microprofile Config to 3.x resteasy/resteasy#2250 also includes relevant documentation in the RESTEasy User Guide:https://github.com/ronsigal/Resteasy/blob/3.10_2406/docbook/reference/en/en-US/modules/Installation_Configuration.xml#L445. The release 4.x version of the same documentation can be read here: https://docs.jboss.org/resteasy/docs/4.4.2.Final/userguide/html/Installation_Configuration.html#microprofile_config

[istraka]

What parameters would be actually excluded? Can you outline an use-case?

[mchoma]

@ronsigal I find that confusing as well. Do I understand it correctly, when resteasy.config.resteasy.parameters.only=true

* servlet init-params [ordinal 60]
* filter init-params [ordinal 50]
* servlet context-params [ordinal 40]

parameters will be exposed only to RestEasy library? Why not to have all parameters available everywhere? Is it to keep backward compatibility of servlet context-params behaviour? Was there before this RFE way for application to consume servlet context-param?

[ronsigal]

Removed reference to "resteasy.config.resteasy.parameters.only"

[ronsigal]

Hi @istraka, @mchoma,

Actually, I backtracked on that, but I see I mentioned it on WFLY-12779, rather than EAP7-1386:

One thing I would like to reconsider is the proposal to implement the parameter "resteasy.config.resteasy.parameters.only". Thinking more about it, it seems awkward to restrict the scope of some ConfigSources when most of them, the default ConfigSources as well as those added in Wildfly, are out of RESTEasy's control. I'm thinking now that it makes more sense to allow any parameters to be retrieved in RESTEasy.

Sorry for the confusion. I'll update the document.

[pkremens]

Could you please elaborate that this one will apply only in case that MicroProfile classes are available

[ronsigal]

Hi @pkremens,

I've rewritten the proposal to account for the fact that RESTEasy must be able to function with or without the availability of MicroProfile Config.

-Ron

[pkremens]

Hi @ronsigal

thanks! It is a public holiday today here in Czech Republic so I'll take a look on Monday.

[pkremens]

Hi @ronsigal,
thanks for updates, looking good to me.

I don't think we need to extend the Test Plan section of this document more, since there will be a separate document in "jbossqe-eap/test-plans" covering that part (we can mention a new profile disable.microprofile.tests also in there, as it will be needed only for EAP testing).