Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-12674 wildfly.jpa.skipquerydetach set to true, will now skip clearing of query results #255

Merged
merged 1 commit into from
May 20, 2020
Merged

WFLY-12674 wildfly.jpa.skipquerydetach set to true, will now skip clearing of query results #255

merged 1 commit into from
May 20, 2020

Conversation

scottmarlow
Copy link
Contributor

bstansberry
bstansberry reviewed Oct 27, 2019
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the 'Testing By' needs to be set and someone from QE should review this.

@scottmarlow
Copy link
Contributor Author

Thanks Brian, just started that conversation via EAP7-1365

@scottmarlow
Copy link
Contributor Author

@bstansberry I updated the 'Testing By' field to be engineering.

@scottmarlow
Copy link
Contributor Author

@simkam could you please approve this pull request after reading the content. Thanks!

@scottmarlow scottmarlow mentioned this pull request Jan 22, 2020
Merged
@bstansberry bstansberry merged commit 7aaced0 into wildfly:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottmarlow @bstansberry