Skip to content

Commit

Permalink
[WFLY-19816] Support regex expression in container interceptors mapping
Browse files Browse the repository at this point in the history
  • Loading branch information
tadamski committed Dec 5, 2024
1 parent 01a3690 commit f8c1ad1
Showing 1 changed file with 59 additions and 23 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
---
categories:
- ejb
- ejb
stability-level: default
issue: https://github.com/wildfly/wildfly-proposals/issues/669
feature-team:
developer: Tomasz Adamski
sme:
-
outside-perspective:
-
---
= Support regex expressions in cointainer interceptors mapping
= [WFLY-19816] Support regex expressions in cointainer interceptors mapping
:author: Tomasz Adamski
:email: [email protected]
:toc: left
:icons: font
Expand All @@ -11,29 +20,34 @@ categories:

== Overview

=== Issue
* https://issues.redhat.com/browse/WFLY-19816
Apart from Jakarta EE interceptors, which are mandated by the spec and run after all server specific interceptors, WildFly allows for configuration of container interceptors, which are run before those server specific interceptors. WildFly support for regular expression in Jakarta EE interceptors is already implemented and supported. Such functionality is not supported for container interceptors though. This seems an oversight as there is no reason why regular expressions should be not supported for container interceptors.


=== Dev Contacts
=== User Stories

* mailto:[email protected]
Users would like to be able to configure container interceptors using regular expressions in the same way they can do it for Jakarta EE interceptors.

=== QE Contacts
== Issue Metadata

=== Testing By
[x] Engineering
=== Related Issues

[] QE
https://issues.redhat.com/browse/WFLY-6979 - this is the implementation for Jakarta EE interceptors

=== Affected Projects or Components
EJBs

== Introduction
https://github.com/wildfly/wildfly
https://github.com/wildfly/wildfly-core

Apart from Jakarta EE interceptors, which are mandated by the spec and run after all server specific interceptors, WildFly allows for configuration of container interceptors, which are run before those server specific interceptors. WildFly support for regular expression in Jakarta EE interceptors is already implemented and supported. Such functionality is not supported for container interceptors though. This seems an oversight as there is no reason why regular expressions should be not supported for container interceptors.
=== Other Interested Projects

=== Relevant Installation Types

== Proposed solution
* Traditional standalone server (unzipped or provisioned by Galleon)
* Managed domain
* OpenShift Source-to-Image (S2I)
* Bootable jar

== Requirements

The proposed solution is to clone regular interceptor support from Jakarta EE interceptors to container interceptors.

Expand Down Expand Up @@ -74,18 +88,40 @@ After that there would be possibility to use regular expressions in names of ejb
----
[source]

== Implementation

The draft implementation is present in the following branches:
https://issues.redhat.com/browse/WFCORE-7025
https://issues.redhat.com/browse/WFLY-19816
== Backwards Compatibility

== Test Plan
I'm not anticipating backward compatibility issues. This is the new functionality and the configurations that were valid before, that is without regular expression, should work just fine after this feature is merged.

=== Default Configuration

* no change

=== Importing Existing Configuration

* no impact

=== Deployments

Jakarta EE interceptors support for regular expression is already well tested (_org.jboss.as.test.integration.ejb.interceptor.regex_ package of WildFly's basic integration testsuite). Those tests should be cloned for cointainer interceptors.
* no

Test implementation is also present in:
https://issues.redhat.com/browse/WFLY-19816
=== Interoperability

* no


== Admin Clients

* no impact on admin clients


[[test_plan]]
== Test Plan

This feature is already implemented,tested for Jakarta EE interceptors and for this configuration it is working fine. I suggest clonning existing Jakarta EE interceptors integration tests to verify the behavior of container interceptors.

== Community Documentation
There is no need for community documentation.

I don't think additional community documentation is required for this feature.


0 comments on commit f8c1ad1

Please sign in to comment.