Skip to content

Commit

Permalink
WFLY-19592 Define Telemetry and Micrometer metrics in the MicroProfil…
Browse files Browse the repository at this point in the history
…e Fault Tolerance 4.1 upgrade.
  • Loading branch information
rhusar committed Dec 4, 2024
1 parent fd1c063 commit 26bb44b
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion microprofile/WFLY-19592_MicroProfile_Fault_Tolerance_4_1.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ promoted-by:
== Overview

The goal is to integrate MicroProfile (MP) Fault Tolerance (FT) 4.1 specification from the MP Platform 7.0 to WildFly at default stability level.
The specification is implemented by SmallRye (SR) FT project.
To certify functionality, the MP FT TCK is run as part of the WildFly testsuite.

=== User Stories
Expand Down Expand Up @@ -58,8 +59,21 @@ Users electing to employ MicroProfile Telemetry metrics will have MicroProfile F
== Requirements

* Upgrade MP FT specification modules to 4.1.
* Upgrade SmallRye FT to 6.5.x.
* Upgrade SmallRye FT to latest relevant version that implements this spec.
* Enable collecting metrics with MP Telemetry when the subsystem is available in the server configuration.
** Simultaneous metrics collection:
Historically, when WildFly removed MP Metrics support,
we have provided an optional Micrometer integration in SR FT in order to keep providing metrics collection support.
This integration is not defined by the FT spec.
The MP FT 4.1 spec defined MP Telemetry metrics collection.
The spec also defines concurrent collection when both MP Metrics and MP Telemetry is available.
Analogously, when both subsystems are available, we will collect metrics also with Micrometer.
While this is helpful for instance as an upgrade path,
simultaneous metrics collection might not be desirable in all situations.
For that purpose, we will be supporting MP Config properties to fine-tune metrics collectors in use.
These properties `smallrye.faulttolerance.micrometer.disabled` and `smallrye.faulttolerance.opentelemetry.disabled`
are now supported by upstream SR FT (since SR FT 6.6.3 and 6.7.0) and documented.
Note, that this is in addition to an existing spec-defined MP Config property to disable metrics collection by MP FT altogether.

=== Changed requirements

Expand Down

0 comments on commit 26bb44b

Please sign in to comment.