Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to new wildfly-cli fat client shaded model #86

Closed
jfdenise opened this issue Nov 7, 2024 · 5 comments · Fixed by #87
Closed

Adapt to new wildfly-cli fat client shaded model #86

jfdenise opened this issue Nov 7, 2024 · 5 comments · Fixed by #87

Comments

@jfdenise
Copy link
Contributor

jfdenise commented Nov 7, 2024 •
edited
Loading

Issue: https://issues.redhat.com/browse/WFMP-279
WildFly is producing a model of the shaded wildfly-cli:client fat jar. This shaded model should be used to construct CLI classloader.
jfdenise added a commit to jfdenise/wildfly-plugin-tools that referenced this issue Nov 7, 2024
@jfdenise
Fix for Issue wildfly#86, Adapt to new wildfly-cli fat client shaded …
419562d 
…model
jfdenise added a commit to jfdenise/wildfly-plugin-tools that referenced this issue Nov 7, 2024
@jfdenise
Fix for Issue wildfly#86, Adapt to new wildfly-cli fat client shaded …
a109c84 
…model
@jamezp jamezp mentioned this issue Nov 7, 2024
Merged
@jamezp jamezp linked a pull request Nov 7, 2024 that will close this issue
Fix for Issue #86, Adapt to new wildfly-cli fat client shaded model #87
Merged
@jamezp
Copy link
Member

jamezp commented Nov 7, 2024

Is there a JIRA for the task that added this?

@jfdenise
Copy link
Contributor Author

@jamezp , I logged: https://issues.redhat.com/browse/WFMP-279

@jamezp
Copy link
Member

jamezp commented Nov 11, 2024

@jfdenise Sorry, I meant a WFLY or WFCORE JIRA. From what it looks like org.wildfly.core.wildfly-cli.shaded package which I assume is part of either the WildFly or WildFly Core feature packs. There is no JavaDoc to GalleonFeaturePackRuntime.GalleonPackageRuntime(), but my assumption on reading the code is it will simply return null if not found. Is that correct?

I guess what I didn't know is what org.wildfly.core.wildfly-cli.shaded is, but I'm assuming it must be a package in the feature pack.

jfdenise added a commit to jfdenise/wildfly-plugin-tools that referenced this issue Nov 11, 2024
@jfdenise
Fix for Issue wildfly#86, Adapt to new wildfly-cli fat client shaded …
e219d51 
…model
@jfdenise
Copy link
Contributor Author

@jamezp , I see, The JIRA that introduced this package is: https://issues.redhat.com/browse/WFCORE-7019

@jamezp
Copy link
Member

jamezp commented Nov 11, 2024

Perfect, thank you! I'll give it a test.

jamezp added a commit that referenced this issue Nov 11, 2024
@jamezp
Merge pull request #87 from jfdenise/Issue_86
0f71fe5 
Fix for Issue #86, Adapt to new wildfly-cli fat client shaded model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Issue #86, Adapt to new wildfly-cli fat client shaded model jfdenise/wildfly-plugin-tools
2 participants
@jamezp @jfdenise