-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed autoscaling with the hpa #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my comment on the label, this looks good.
Thanks a lot for fixing this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Good evening, any progress with this pull request? |
I'm closing your PR as it has been merged in the aggregated PR #215. Thanks! |
Added a Resources field to the
WildFlyServerSpec
type.This will allow the user to specify the CPU requirement for containers,
which is mandatory for the HPA calculation of CPU utilization.
Example of HPA eligible application:
Added a string
Selector
field of type string to theWildFlyServerStatus
type.This will be used for storing the selector label which is populated by the operator with the key app.kubernetes.io/instance.
The value for the label is created from the prefix
wildfly-
concatenated with the application name.The same label is also applied to the underlying containers via the StatefulSet's template.
This is required for targeting the CR with the HPA instead of the underlying StatefulSet,
which is required to maintain the CR as the source for any of its resources.