Upgrade prospero-metadata to 1.3.0.Beta2 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasHofman
force-pushed
the
prospero-1.3
branch
from
b52d0a3 to
d59f7ca
Compare
|
This needs to be reviewed by @spyrkob . |
spyrkob
approved these changes
Dec 3, 2024
jamezp
reviewed
Dec 5, 2024
| @@ -186,8 +186,7 @@ private void resolveFromChannels(MavenArtifact artifact) throws UnresolvedMavenA | |||
|
|
|||
| public void done(Path home) throws MavenUniverseException, IOException { | |||
| ChannelManifest channelManifest = channelSession.getRecordedChannel(); | |||
| final ManifestVersionRecord currentVersions = new ManifestVersionResolver(localCachePath, system) | |||
| .getCurrentVersions(channels); | |||
| final ManifestVersionRecord currentVersions = ManifestVersionResolver.getCurrentVersions(channelSession); | |||
There was a problem hiding this comment.
Is there a reason for this change?
There was a problem hiding this comment.
@jamezp I deprecated the old method - it was relying on a hack I want to get rid of. The new method uses changed wildfly-channel API to achieve the same goal more cleanly.
There was a problem hiding this comment.
Yeah, that was really @spyrkob 's request.
|
@TomasHofman prospero-metadata 1.3.0.Final should be out now, do you want to update this PR or should I open a new one? |
|
I will update 👍 |
TomasHofman
force-pushed
the
prospero-1.3
branch
from
d59f7ca to
f345548
Compare
jamezp
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the prospero-metadata version minor relevant to next EAP stream.