[WFMP-262]: Allow to add labels to the images. #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding a labels parameter. Issue: https://issues.redhat.com/browse/WFMP-262 Signed-off-by: Emmanuel Hugonnet <[email protected]>
jamezp
reviewed
Jun 6, 2024
Comment on lines
+111
to
+112
| String WILDFLY_IMAGE_LABELS = "wildfly.image.labels"; | ||
|
|
There was a problem hiding this comment.
Not a blocker, but this doesn't need to be here if you'd rather it not be. I had originally created this file for shared properties to ensure the values stay the same, but this is likely not to be shared.
Comment on lines
+100
to
+101
| @Parameter(property = WILDFLY_IMAGE_LABELS, alias = "labels", required = false) | ||
| private List<String> labels = Collections.emptyList(); |
There was a problem hiding this comment.
Should this be a Map<String, String> instead so it can be defined like:
<labels>
<version>1.0</version>
<description>"Test description "</description>
</labels>Also the alias and required aren't really needed.
| @@ -29,6 +29,11 @@ | |||
| <image> | |||
| <group>wildfly-maven-plugin</group> | |||
| </image> | |||
| <labels> | |||
| <label>version="1.0"</label> | |||
| <label>description="This text illustrates \ | |||
There was a problem hiding this comment.
Minor, but the quotes should be " to be valid XML :)
jamezp
reviewed
Jun 6, 2024
| @@ -95,6 +97,9 @@ public class ApplicationImageMojo extends PackageServerMojo { | |||
| @Parameter(alias = "image") | |||
| private ApplicationImageInfo image; | |||
|
|
|||
| @Parameter(property = WILDFLY_IMAGE_LABELS, alias = "labels", required = false) | |||
There was a problem hiding this comment.
This needs some Java doc for the plugin documentation. In that it needs a @since 5.0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFMP-262