[5.x] Add support for WildFly Glow #374
Conversation
| } | ||
| if (results.getErrorSession().hasErrors()) { | ||
| if (discoverProvisioningInfo.isFailsOnError()) { | ||
| throw new MojoExecutionException("Error detected by glow. Aborting."); |
There was a problem hiding this comment.
Will errors be printed somewhere? What I mean by this, is will glow log some kind of error?
There was a problem hiding this comment.
Yes, glow has a pluggable message writer tha , in the plugin cases route logs to maven logs: https://github.com/jfdenise/wildfly-maven-plugin/blob/glow-only/plugin/src/main/java/org/wildfly/plugin/common/GlowMavenMessageWriter.java
BTW I am changing glow by "WildFly Glow"
| @@ -195,6 +202,9 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| getLog().debug(String.format("Skipping " + getGoal() + " of %s:%s", project.getGroupId(), project.getArtifactId())); | |||
| return; | |||
| } | |||
| if (dryRun) { | |||
| getLog().info("Dry run execution, no server provisioned."); | |||
There was a problem hiding this comment.
Minor, but I think we should say something like "Dry run execution, no server will be provisioned"
| Path targetPath = Paths.get(project.getBuild().getDirectory()); | ||
| Path file = targetPath.resolve(PLUGIN_PROVISIONING_FILE); | ||
| getLog().info("Dry-run execution, generating provisioning.xml file: " + file); | ||
| try (FileWriter writer = new FileWriter(file.toFile())) { |
There was a problem hiding this comment.
IMO we should use something like:
try (BufferedWritter writer = Files.newBufferedWriter(file, StandardCharsets.UTF_8) {| List<Path> lst = new ArrayList<>(); | ||
| lst.add(deployment); |
There was a problem hiding this comment.
If this is the only entry, we should just use List.of(deployment);.
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Show resolved
Hide resolved
|
Failure is unrelated to this change. Known instability when producing the docker image. |
| // The first packaging was not an exploded war, clean it. | ||
| if (requiresWarDeletion) { | ||
| final Path path = resolveWarLocation(); | ||
| deleteRecursively(path); | ||
| requiresWarDeletion = false; | ||
| repackaged = true; | ||
| } |
There was a problem hiding this comment.
We should likely perform an undeploy, at least if it's not remote, before we delete the path.
There was a problem hiding this comment.
@jamezp , thank-you. I found some issues with the remote goal that I fixed. When remote is enabled, this logic shouldn't be applied and the reprovisioning/re-start shouldn't occur. I also found an issue with the directory name used by the war plugin when the "war" goal is used. In this case, the directory can't contain the .war extension. This extension has been added for Glow to understand what kind of exploded deployment we are dealing with. In the remote case, Glow scanning is meaningless.
|
I've also bumped main to 5.0.0.Alpha1-SNAPSHOT |
|
Failing test is un-related to this change. |
No description provided.