WFMP-177 and WFMP-178 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
reviewed
Jan 25, 2023
Comment on lines
-181
to
+180
| List<ChannelCoordinate> channels; | ||
| List<ChannelConfiguration> channels; |
There was a problem hiding this comment.
What are the differences here? Are there parameter name differences? If so we'll need to change the version to something like 4.1.0 before this can be merged.
There was a problem hiding this comment.
@jamezp , yes we have an incompatible change there, we introduce a sub element manifest-coordinate inside a Channel. +1 for 4.1.0, I was going to suggest it.
jamezp
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
https://issues.redhat.com/browse/WFMP-177
https://issues.redhat.com/browse/WFMP-178
Latest changes introduced in wildfly-channel 1.0.0.Beta4
Use prospero project to generate metadata file when channels are setup.