[WFCORE-6609] remove obsolete JMockit #5766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
fjuma
reviewed
Nov 15, 2023
There was a problem hiding this comment.
@soul2zimate Thanks for working on this! It's great that this is no longer needed by the tests. This looks good, the WFCORE issue in the title and commit message just needs to be updated (it's currently "WFCORE-").
soul2zimate
force-pushed
the
remove-jmockit-main
branch
from
7232a26 to
93d0824
Compare
soul2zimate
changed the title
|
yes, I created a new issue and linked in the title and commit message. |
This comment was marked as off-topic.
This comment was marked as off-topic.
yersan
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Great @soul2zimate , looks good, the test failure can be ignored since it is not related. Waiting for approval from Elytron team.
yersan
added
the
ready-for-merge
|
Thanks @fjuma @soul2zimate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-6609 remove obsolete JMockit