Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website update for OSD 2024 #2182

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

PrarthonaPaul
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul commented Aug 19, 2024

Preview: https://prarthonapaul.github.io/wildfly-elytron/OSD/
hacktoberfest preview: https://prarthonapaul.github.io/wildfly-elytron/hacktoberfest/

TODO for OSD:
If a banner for OSD2024 is available, that should be added

TODO for hacktoberfest:
add a banner for this year inside assets/images/posts/ once it is available.
Confirm this: You’ll have the option to have a tree planted in your name and you can obtain a unique digital reward. Visit the Hacktoberfest site for more information.

Small update is added to fix the header for blog page.

@fjuma
Copy link
Contributor

fjuma commented Aug 19, 2024

@PrarthonaPaul Feel free to include the hacktoberfest commit in this one too so both can be previewed and merged together.

Just noticed the OSD image is quite large and a bit blurry.

If we can't make that smaller, we could just remove the graphic for now or maybe just use a standard generic GHC logo instead?

@PrarthonaPaul
Copy link
Contributor Author

PrarthonaPaul commented Aug 19, 2024

Hi @fjuma
I got rid of the picture for the banner, but still kept it for the metadata, so when the link is shared, this picture would show up. Like this:
image

And I have added the hacktoberfest commit here as well.

@fjuma
Copy link
Contributor

fjuma commented Aug 19, 2024

Is it possible to have buttons for "Open Source Day" and "Hacktoberfest" appear at the top of the homepage? Right now, I just see "OSD 2024"

@PrarthonaPaul
Copy link
Contributor Author

Is it possible to have buttons for "OSD" and "Hacktoberfest" appear at the top of the homepage?

Done!
https://prarthonapaul.github.io/wildfly-elytron/
The homepage still does say "Welcome new Open Source Day participants! Click here to get started!".

Should I add one for hacktoberfest as well? or leave it as is?

@fjuma
Copy link
Contributor

fjuma commented Aug 19, 2024

Just some small nits:

  • Let's rename "OSD 2024" to "Open Source Day"
  • Can we put that before Hacktoberfest?
  • Is it possible to introduce some spacing between the buttons?

We can leave the welcome message as is so it stands out for the Open Source Day participants.

@PrarthonaPaul PrarthonaPaul force-pushed the develop branch 2 times, most recently from 59464e2 to 9f98894 Compare August 19, 2024 20:21
@PrarthonaPaul
Copy link
Contributor Author

PrarthonaPaul commented Aug 19, 2024

Hi @fjuma
done! Preview can be found here: https://prarthonapaul.github.io/wildfly-elytron/
The space between the buttons might take a while to show up.

@fjuma fjuma merged commit 0a89650 into wildfly-security:develop Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants