Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELY-2778 Replace string literals inside the OidcJsonConfiguration class with constants #2165

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

PrarthonaPaul
Copy link
Contributor

@fjuma fjuma requested a review from ivassile August 15, 2024 18:36
Copy link
Contributor

@ivassile ivassile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrarthonaPaul You have to change the tests to also use the new constants.

@PrarthonaPaul
Copy link
Contributor Author

@PrarthonaPaul You have to change the tests to also use the new constants.

Thanks @ivassile
I have edited the tests to use the constants.

@fjuma
Copy link
Contributor

fjuma commented Aug 19, 2024

This one will need a rebase now.

@PrarthonaPaul
Copy link
Contributor Author

This one will need a rebase now.

Hi @fjuma This PR is good to go now

@darranl darranl merged commit d4fe65f into wildfly-security:2.x Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants