Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2774] Move CAGenerationTool to PKCS#12 #2162

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Jun 26, 2024

This is a follow up from #2161 this adds a commit to switch the test to a PKCS#12 KeyStore.

I am starting with this as a draft PR as we probably want the first merged first and projects depending on the CA utility to use the utility to load the stores before we then switch the default over.

https://issues.redhat.com/browse/ELY-2774

darranl added 4 commits June 24, 2024 15:50
…create their own artifacts.

This include KeyManager, TrustManager and KeyStore instances.

A CustomIdentity variant is also present for tests that create their own
identities.
…SSL artifacts instead of doing it themselves.
@darranl darranl added the hold label Jun 26, 2024
@darranl darranl marked this pull request as ready for review June 27, 2024 19:21
@darranl darranl requested review from fjuma and Skyllarr as code owners June 27, 2024 19:21
@darranl
Copy link
Contributor Author

darranl commented Jun 27, 2024

@fjuma FYI I have added one more commit to this one for the move to PKCS#12, I could not quite get WildFly Core ready for the update with these changes so I have a commit in this branch to go with the next Elytron component upgrade:

https://github.com/darranl/wildfly-core/tree/WFCORE-6869

@darranl darranl removed the hold label Jul 4, 2024
@darranl
Copy link
Contributor Author

darranl commented Jul 4, 2024

@fjuma Can we add the Critical label to include this in the next Elytron tag which will be prepared for WildFly? I also need to get a release JBoss Remoting can use to reenable TLS testing there. It is feeling like this is complete now, just one more test to enable.

@fjuma fjuma added the Critical label Jul 4, 2024
@fjuma
Copy link
Contributor

fjuma commented Jul 4, 2024

Thanks @darranl! Am planning on tagging 2.5.0.Final on Monday.

@fjuma fjuma merged commit 00230a4 into wildfly-security:2.x Jul 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants