[ELY-2723] Fix failures in SSLAuthenticationTestCase with SE 21 #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks @Skyllarr! Since the Elytron OCSP tests in WildFly also depend on the same org.glassfish.jaxb.jaxb-runtime version, I think we could get this merged and get a follow up issue created to upgrade both the ocsp-server and org.glassfish.jaxb.jaxb-runtime versions.
|
@fjuma Good point, I created https://issues.redhat.com/browse/ELY-2736 and https://issues.redhat.com/browse/WFLY-19144 for upgrading the versions and I'm removing the hold label |
|
@ivassile This one can be reviewed if you'll have some time. Thank you! |
ivassile
approved these changes
Mar 19, 2024
|
@fjuma Just noticed that this one can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2723
This solution passes on JDK 21 but it is not ideal as the dependency version <version.org.glassfish.jaxb.jaxb-runtime>2.4.0-b180830.0438</version.org.glassfish.jaxb.jaxb-runtime> is older and contains vulnerabilities: https://mvnrepository.com/artifact/org.glassfish.jaxb/jaxb-runtime/2.4.0-b180830.0438 . This specific version is also used in wildfly repo: https://github.com/wildfly/wildfly/blob/main/testsuite/integration/elytron/pom.xml#L46 but it should be updated there as well. When I update the version to latest, the test does not pass anymore. So this needs further investigation later.