[ELY-2684] Unit test code refactor (removed duplicates) #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugan0tech
force-pushed
the
sugan0tech/ELY-2684
branch
from
38b6a5e to
1a66c35
Compare
fjuma
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Looks good, @sugan0tech, I've just added a small comment.
For the title and commit message, it would be good to include information about the specific test that was updated, e.g., [ELY-2648] Update tests in OTPTest to use a common helper method for tests where the password should remain unchanged"
| @@ -1082,6 +994,40 @@ private CallbackHandler createClientCallbackHandler(String username, String pass | |||
| return ClientUtils.getCallbackHandler(new URI("remote://localhost"), context); | |||
| } | |||
|
|
|||
| private void testAuthentication(String seed, int sequenceNumber) throws Exception { | |||
There was a problem hiding this comment.
Would be good to rename this to explain what it does, e.g., checkPasswordRemainsUnchanged or testPasswordRemainsUnchanged, etc.
…the tests with unchanged passwords.
sugan0tech
force-pushed
the
sugan0tech/ELY-2684
branch
from
1a66c35 to
075dcb3
Compare
fjuma
approved these changes
Oct 25, 2023
PrarthonaPaul
approved these changes
Oct 25, 2023
Skyllarr
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2684