Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2694] Update assertEquals calls in CommandCredentialSourceTest s… #2018

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[ELY-2694] Update assertEquals calls in CommandCredentialSourceTest s… #2018

merged 1 commit into from
Oct 17, 2023

Conversation

map-b
Copy link
Contributor

@map-b map-b commented Oct 16, 2023 •
edited
Loading

…o that the expected value and actual value are passed in the correct order

https://issues.redhat.com/browse/ELY-2694

@map-b
[ELY-2694] Update assertEquals calls in CommandCredentialSourceTest s…
11bf990 
…o that the expected value and actual value are passed in the correct order
@map-b map-b requested review from fjuma and Skyllarr as code owners October 16, 2023 17:39
PrarthonaPaul
PrarthonaPaul approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @map-b

fjuma
fjuma approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@map-b Welcome to the WildFly Elytron project and thanks for the PR, it looks good!

@Skyllarr Skyllarr merged commit 955b5a6 into wildfly-security:2.x Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrarthonaPaul PrarthonaPaul PrarthonaPaul approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted +1 FJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@map-b @fjuma @Skyllarr @PrarthonaPaul