[ELY-2685] Replace assert in PasswordBasedEncryptionUtilTest with a p… #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrarthonaPaul
suggested changes
Oct 13, 2023
| Assert.assertTrue("Elytron in PB compatible mode failed", decrypted.equals(secret)); | ||
| Assert.assertTrue("PicketBox encrypted, Elytron decrypted in compatible mode, failed", crossDecrypted.equals(secret)); | ||
| Assert.assertTrue("Elytron in compatible mode encrypted, PicketBox encrypted must be the same", pbGenerated.equals(encrypted)); | ||
| Assert.assertEquals("Elytron in PB compatible mode failed", decrypted, secret); |
There was a problem hiding this comment.
Thank you @ericrleung for the PR!
Very minor, but could you please change the order of the values so it is following the format assertTrue( message, expectedValue, actualValue) ? Thank you! Here, I believe secret and encrypted are the expected values.
Skyllarr
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roper check
https://issues.redhat.com/browse/ELY-2685