[ELY-2612] removed duplicates in BasicScramSelfTest

[sugan0tech]

https://issues.redhat.com/browse/ELY-2612

[fjuma]

Thanks for your contribution @sugan0tech, I've added some feedback.

[sugan0tech]

@fjuma I have updated the requested changes. Thanks 👍 . BTW i can see the same changes required in other section of code too.

[fjuma]

In this line:

final SaslServer saslServer =
                new SaslServerBuilder(ScramSaslServerFactory.class, SaslMechanismInformation.Names.SCRAM_SHA_1)
                        .setUserName("user")
                        .setPassword("pencil".toCharArray())
                        .build();

We are configuring a username ("user") and password ("pencil") to be used on the server side.

In this line:

CallbackHandler clientHandler = createClientCallbackHandler("wrong", "pencil".toCharArray());

We are specifying the username ("wrong") and password ("pencil") to be used on the client side.

In this line:

testAuthentication(SaslMechanismInformation.Names.SCRAM_SHA_1, saslServer, clientHandler, "user", EMPTY);

We are specifying the authorizationId to be used. Here, we are using the same username that was specified in the server side configuration above ("user").

So in the common performAuthenticationTest method that's being added below, we need to make sure we use different variables for the server side and client side configuration, e.g., username and password could be used for the server side configuration and clientUsername and clientPassword could be used for the client side configuration. We can update the method to take these 4 parameters.

You'll then need to go through each test that's been updated here and make sure the performAuthenticationTest is being called with the right parameters.

[sugan0tech]

@fjuma I have updated those changes.

[fjuma]

Thanks @sugan0tech, looks good!