[ELY-2610] migrate getAccessTokenHash method to AtValidator class. #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrarthonaPaul
suggested changes
Oct 10, 2023
http/oidc/src/main/java/org/wildfly/security/http/oidc/TokenValidator.java
Outdated
Show resolved
Hide resolved
sugan0tech
force-pushed
the
sugan0tech/ELY-2610
branch
from
17c8dc4 to
9f99df6
Compare
PrarthonaPaul
approved these changes
Oct 11, 2023
fjuma
requested changes
Oct 11, 2023
| @@ -263,7 +263,7 @@ public ErrorCodeValidator.Error validate(JwtContext jwtContext) throws Malformed | |||
| String atHash = jwtClaims.getStringClaimValue(AT_HASH); | |||
| String actualHash; | |||
| try { | |||
| actualHash = getAccessTokenHash(accessTokenString, jwsAlgorithm); | |||
| actualHash = getAccessTokenHash(accessTokenString, jwsAlgorithm); | |||
There was a problem hiding this comment.
Just a very small thing, but just noticed that an extra white space was added here. In general, it's good practice to avoid making unrelated white space changes in PRs.
| * | ||
| * @return the access token hash claim | ||
| */ | ||
| public String getAccessTokenHash() { |
There was a problem hiding this comment.
We don't need to remove this method. This method is different from the private getAccessTokenHash method in the TokenValidator file.
sugan0tech
force-pushed
the
sugan0tech/ELY-2610
branch
from
9f99df6 to
4198c90
Compare
fjuma
approved these changes
Oct 11, 2023
Skyllarr
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2610