Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2621] Add a test that makes use of the RoleMapper#or method to R… #1997

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[ELY-2621] Add a test that makes use of the RoleMapper#or method to R… #1997

merged 1 commit into from
Oct 10, 2023

Conversation

ericrleung
Copy link
Contributor

@PrarthonaPaul
Copy link
Contributor

Hi @ericrleung welcome to the WildFly Elytron project! Thank you very much for your contribution!
Just a note, for any future PRs you submit, it is a good practice to create a separate branch on your fork and work on it there (I see you are submitting this PR off of 2.x branch from your fork). Generally, we name it after the ELY issue number, but you can name it anything. You can use git checkout -b <branch name> to create the branch.

PrarthonaPaul
PrarthonaPaul approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ericrleung

PrarthonaPaul
PrarthonaPaul approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fjuma
fjuma approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericrleung!

@Skyllarr
Copy link
Contributor

@ericrleung Thank you looks great! Just a minor, can you please rebase your change on 2.x branch to resolve the conflict on this PR?

@Skyllarr Skyllarr merged commit b4c9670 into wildfly-security:2.x Oct 10, 2023
3 checks passed
@Skyllarr
Copy link
Contributor

@ericrleung Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrarthonaPaul PrarthonaPaul PrarthonaPaul approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted rebase this +1 DV +1 FJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericrleung @PrarthonaPaul @Skyllarr @fjuma