[ELY-2615] Add a test class that tests creating and making use of a custom NameRewriter #1993
Conversation
| } else if (original.equals("bob")) { | ||
| return "Robert"; |
There was a problem hiding this comment.
Thank you for the PR!
Something minor: since you have "bob" and "Robert" Configured as constants, are you able to use those here instead?
| private static final String BEFORE_USER_NAME = "bob"; | ||
| private static final String AFTER_USER_NAME = "Robert"; |
There was a problem hiding this comment.
This is very small, but "bob" is all lowercase, and "Robert" has a capital R. Is there a reason for that?
If not, could we change it to "Bob" instead?
| .setPreRealmRewriter(rewriter) | ||
| .build(); | ||
| ServerAuthenticationContext sac = securityDomain.createNewAuthenticationContext(); | ||
| sac.setAuthenticationName("john"); |
There was a problem hiding this comment.
same here, could it be changed to "John"?
|
|
||
| private FileSystemSecurityRealm createSecurityRealm() throws Exception { | ||
| FileSystemSecurityRealm realm = new FileSystemSecurityRealm(ServerUtils.getRootPath(true, getClass())); | ||
| ServerUtils.addUser(realm, "Robert"); |
There was a problem hiding this comment.
Are you able to use the AFTER_USER_NAME constant here?
|
Hi @PrarthonaPaul, thank you for your review, your suggestion should be addressed now. |
| @@ -0,0 +1,75 @@ | |||
| package org.wildfly.security.auth.server; | |||
There was a problem hiding this comment.
@lvydra Just a minor, can you please add a license on top of the file? Thank you!
…ustom NameRewriter
|
@lvydra Thanks! |
https://issues.redhat.com/browse/ELY-2615