[ELY-2601] declared newMap on a separate line in PasswordKeyStoreSpi #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nasonawa |
|
Hi @PrarthonaPaul |
PrarthonaPaul
approved these changes
Sep 28, 2023
Skyllarr
reviewed
Sep 29, 2023
| @@ -91,7 +91,9 @@ public void engineSetEntry(final String alias, final KeyStore.Entry entry, final | |||
| if (protParam != null) { | |||
| throw log.keyCannotBeProtected(alias); | |||
| } | |||
| HashMap<String, PasswordEntry> map, newMap; | |||
| HashMap<String, PasswordEntry> map; | |||
| HashMap<String,PasswordEntry> newMap; | |||
There was a problem hiding this comment.
@nasonawa Justa t total minor, can you please fix the formatting by adding a space before the PasswordEntry of newMap initialization? Thank you!
|
Hi @Skyllarr |
Skyllarr
approved these changes
Sep 29, 2023
|
@nasonawa Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELY-2601 newMap on a separate line in PasswordKeyStoreSpi