ELY-2629: Move method permissionFor in IntNameSetPermissionCollection class

[deepalik-neu]

https://issues.redhat.com/browse/ELY-2629

[ashley-abdelsayed98]

hi @deepalik-neu, thank you for your contribution! can you please link the JIRA issue in the PR description?

[Skyllarr]

@deepalik-neu thank you so much Deepali! Just a minor, the commit message should include the jira issue number. Let us know if you need any help with that

[deepalik-neu]

Thank you for letting me know.
https://issues.redhat.com/browse/ELY-2629

[Skyllarr]

@deepalik-neu You can rename your commit by using "git commit --amend" and add an issue number there. Thank you!

[Skyllarr]

@deepalik-neu good job! we just now need to squash the commits together. You can follow the steps from Sonia on slack :) You can start with the "git rebase -i HEAD~2"

[Skyllarr]

@deepalik-neu I just noticed that 1 of your current commits is a "merge" commit. So unfortunately the usual interactive rebase with squash will not work. So please follow these steps to squash your commits:

git checkout 2.x
git checkout -b temp
git merge --squash move-permissionFor-method
git commit -m "[ELY-2629] Move method permissionFor in IntNameSetPermissionCollection class"
git branch -D move-permissionFor-method
git checkout -b move-permissionFor-method
git push -f yourRemoteName move-permissionFor-method

For explanation, see this stackoverflow response

[deepalik-neu]

Done. Thank you!

[Skyllarr]

@deepalik-neu Just a total minor, since this method is private , can you please move it under all the public methods? It is our code style to have private methods located under the public methods. Thank you!

[Skyllarr]

@deepalik-neu After you make the changes, you can use the git commit --amend and the change will be appended to the already existing commit, without creating a new one

[SoniaZaldana]

Looks good to me! Thanks @deepalik-neu

[Skyllarr]

@deepalik-neu There are some intermittent failures in the CI, those are unrelated to your changes. So I am re-running the jobs until they pass and then I can merge :)

[deepalik-neu]

Thank you! @Skyllarr