ELY-2638 Simplify test assertions in SSLAuthenticationTest #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nidhiazad , please make sure there is 1 commit for 1 issue. Currently, there is 1 commit with the commit message "Your commit message here" , so please update it. Please also, create a jira acount and assign the issue to you, so other participants know that it was taken. Thank you! |
|
Hi team,
I have created a jira account on mail id ***@***.*** . Is
there any JIRA board for the wildfly issues. I want to assign this issue to
myself on JIRA https://issues.redhat.com/browse/ELY-2630?filter=12383825.
How can i do that? Can you please help?
Thanks and Regards
Nidhi
…On Fri, Sep 22, 2023 at 8:41 AM Diana Křepinská ***@***.***> wrote:
Hello @nidhiazad <https://github.com/nidhiazad> , please make sure there
is 1 commit for 1 issue. Currently, there is 1 commit with the commit
message "Your commit message here" , so please update it. Please also,
create a jira acount and assign the issue to you, so other participants
know that it was taken. Thank you!
—
Reply to this email directly, view it on GitHub
<#1959 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5EDBG7RSXJHBWHHCLIQUTX3WWSNANCNFSM6AAAAAA5CJT4UA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Able to do now.
…On Fri, Sep 22, 2023 at 9:17 AM nidhi azad ***@***.***> wrote:
Hi team,
I have created a jira account on mail id ***@***.*** . Is
there any JIRA board for the wildfly issues. I want to assign this issue to
myself on JIRA https://issues.redhat.com/browse/ELY-2630?filter=12383825.
How can i do that? Can you please help?
Thanks and Regards
Nidhi
On Fri, Sep 22, 2023 at 8:41 AM Diana Křepinská ***@***.***>
wrote:
> Hello @nidhiazad <https://github.com/nidhiazad> , please make sure there
> is 1 commit for 1 issue. Currently, there is 1 commit with the commit
> message "Your commit message here" , so please update it. Please also,
> create a jira acount and assign the issue to you, so other participants
> know that it was taken. Thank you!
>
> —
> Reply to this email directly, view it on GitHub
> <#1959 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE5EDBG7RSXJHBWHHCLIQUTX3WWSNANCNFSM6AAAAAA5CJT4UA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@nidhiazad I will explain this on the preseentation |
|
Hello @nidhiazad , just a minor, please make sure that there is 1 commit for 1 issue. Thank you! |
|
sure I am following this practice of creating 1 branch , 1PR for 1 issue |
Since this issue has another PR, which you are working on, you can go ahead and close this one when you can. Thanks! |
|
Closing this PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2638