ELY-2630, EL-2365 , ELY-2635 #1958
Conversation
nidhiazad
changed the title
|
@nidhiazad There are 2 commits with the same title, please make sure there is only 1 commit for 1 issue. Let us know if you need help with that. Thank you so much! |
|
Hi @nidhiazad it seems that some tests are failing currently. Would you be able to run |
|
I will check the issue and also run mvn clean install with -X and -e tags on my local branch |
| newMap.putAll(webservicesProperties); | ||
| newMap.values().removeIf(Objects::isNull); | ||
| return new AuthenticationConfiguration(this, SET_WEBSERVICES_PROPS, optimizeMap(newMap)); | ||
| return useWebServicesProperties(webServicesProperties); |
There was a problem hiding this comment.
@nidhiazad I am very sorry, this issue should be closed as "won't do", this is not thread safe operation. Please close the jira issue ELY-2630 as won't do, thank you!
There was a problem hiding this comment.
@nidhiazad Thank you for closing the jira issue. You can remove this commit from this PR. Other 2 issues seem okay to me, only you need to rename the commit that fixes the link to jira issues. Let us know if you need any help, thank you!
|
@nidhiazad ELY-2635 was already merged, and ELY-2630 was closed. This PR contains changing of link from https://issues.jboss.org/browse/ELY to https://issues.redhat.com/browse/ELY , which is issue number ELY-2412. Please update this PR to contain only the ELY-2412 change in a single commit. Thank you! |
|
There haven't been any updates on this one in a few weeks so going to close it. Feel free to re-open. Thanks. |
https://issues.redhat.com/browse/ELY-2630, https://issues.redhat.com/browse/ELY-2635, https://issues.redhat.com/browse/ELY-2635