[ELY-1996] SSLContext to support delegation to alternate instances based on peer information. #1488

Skyllarr · 2021-02-15T17:28:49Z

https://issues.redhat.com/browse/ELY-1996

This is PR is meant to be merged before we have a QE pre-check.

Currently it does change public API because as it adds 2 public methods to AuthenticationContextConfigurationClient.java, please see the comment below and let me know if that is ok or I should use a reflection instead.

Skyllarr · 2021-02-15T17:29:48Z

...src/main/java/org/wildfly/security/auth/client/AuthenticationContextConfigurationClient.java

+     * @param authenticationContext the authentication context to examine (must not be {@code null})
+     * @return List of all configured SSL context belonging to the provided authentication context
+     */
+    public List<SSLContext> getConfiguredSSLContexts(AuthenticationContext authenticationContext) throws GeneralSecurityException {


@darranl @fjuma I did not realize before, but when I move the public class DynamicSSLContextSpiImpl from elytron client to dynamic-ssl module, then I can't use these methods without them being public.

So we either add them as public methods and use a disclaimer saying it is not part of the public API (in javadoc/blog etc.), or use a reflection. I decided to do the former but let me know if you think otherwise. Thanks.

I think looking at the two methods we should just accept them in a new public API, I don't think this will affect our plans to include in Elytron 1.16 as the methods have a well defined scope.

wildfly-ci · 2021-02-15T17:33:11Z

Windows Build 626 outcome was FAILURE using a merge of 0b39596
Summary: Exit code 1 (Step: Maven) (new) Build time: 00:00:20

wildfly-ci · 2021-02-15T19:22:29Z

Linux - JDK11 EA 28 Build 632 outcome was UNKNOWN using a merge of 0b39596
Summary: Canceled (Error while applying patch; cannot find commit a4b7686 in the https://github.com/wildfly-security/wildfly-elytron.git repository, possible reason: refs/pull/1488/merge branch was updated and the commit selec... Build time: 00:00:53

wildfly-ci · 2021-02-16T19:44:47Z

Linux - JDK11 EA 28 Build 637 outcome was FAILURE using a merge of 5d759e3
Summary: Tests passed: 484, ignored: 2; exit code 1 (Step: Maven) (new) Build time: 00:01:51

wildfly-ci · 2021-02-16T19:45:50Z

Windows Build 631 outcome was FAILURE using a merge of 5d759e3
Summary: Tests passed: 484, ignored: 2; exit code 1 (Step: Maven) (new) Build time: 00:02:51

fjuma · 2021-02-16T22:16:15Z

@Skyllarr Just noticed that some of the error messages from the GitHub CI jobs look similar to the some of the issues we ran into recently with Zulu JDK. Darran had submitted a PR to ensure that all SSLContext instances in the tests exclusively use the installed providers:

#1474

We'll likely need similar changes in this PR.

Skyllarr · 2021-02-17T09:19:52Z

@Skyllarr Just noticed that some of the error messages from the GitHub CI jobs look similar to the some of the issues we ran into recently with Zulu JDK. Darran had submitted a PR to ensure that all SSLContext instances in the tests exclusively use the installed providers:

#1474

We'll likely need similar changes in this PR.

@fjuma yes that was the problem. Thanks a lot!

fjuma · 2021-03-02T21:48:03Z

dynamic-ssl/pom.xml

+    <parent>
+        <groupId>org.wildfly.security</groupId>
+        <artifactId>wildfly-elytron-parent</artifactId>
+        <version>1.14.3.CR1-SNAPSHOT</version>


This version now needs to be updated.

wildfly-ci · 2021-03-03T10:33:41Z

Linux - JDK11 EA 28 Build 657 outcome was FAILURE using a merge of f37301d
Summary: Exit code 1 (Step: Maven) (new) Build time: 00:00:21

wildfly-ci · 2021-03-03T10:33:43Z

Windows Build 649 outcome was FAILURE using a merge of f37301d
Summary: Exit code 1 (Step: Maven) (new) Build time: 00:00:23

…sed on peer information.

fjuma · 2021-03-04T22:43:28Z

auth/client/pom.xml

-            <groupId>org.kohsuke.metainf-services</groupId>
-            <artifactId>metainf-services</artifactId>
-            <scope>provided</scope>
-        </dependency>


@Skyllarr Just wondering why this is being removed. It looks like it was added for RESTEasy integration:

#1340

@fjuma it maybe does not belong to this PR but I noticed it is a double dependency. The same dependency is in this file on line 118.

Thanks @Skyllarr, I didn't realize it was a duplicate.

fjuma · 2021-05-31T15:04:33Z

dynamic-ssl/pom.xml

+    <parent>
+        <groupId>org.wildfly.security</groupId>
+        <artifactId>wildfly-elytron-parent</artifactId>
+        <version>1.15.1.CR1-SNAPSHOT</version>


This version will need to be updated.

The base branch was changed.

Skyllarr commented Feb 15, 2021

View reviewed changes

Skyllarr force-pushed the dynamic-ssl-elytron-part branch from 3c1308f to 0b39596 Compare February 15, 2021 17:32

Skyllarr force-pushed the dynamic-ssl-elytron-part branch 4 times, most recently from bfdc8a5 to 5d759e3 Compare February 16, 2021 19:38

Skyllarr force-pushed the dynamic-ssl-elytron-part branch 4 times, most recently from 65886f8 to 46cfe35 Compare February 16, 2021 21:12

Skyllarr force-pushed the dynamic-ssl-elytron-part branch from 46cfe35 to 7f2a2d5 Compare February 17, 2021 09:08

fjuma reviewed Mar 2, 2021

View reviewed changes

Skyllarr force-pushed the dynamic-ssl-elytron-part branch from 7f2a2d5 to f37301d Compare March 3, 2021 10:31

[ELY-1996] SSLContext to support delegation to alternate instances ba…

77574fd

…sed on peer information.

Skyllarr force-pushed the dynamic-ssl-elytron-part branch from f37301d to 77574fd Compare March 3, 2021 10:38

fjuma reviewed Mar 4, 2021

View reviewed changes

fjuma previously approved these changes Mar 5, 2021

View reviewed changes

fjuma added the +1 FJ label Mar 5, 2021

fjuma reviewed May 31, 2021

View reviewed changes

fjuma changed the base branch from 1.x to 2.x January 31, 2023 16:11

fjuma mentioned this pull request Dec 11, 2023

[ELY-1996] [Community] SSLContext to support delegation to alternate instances based on peer information. #1382

Merged

fjuma added hold rebase this labels Dec 12, 2023

Skyllarr closed this Mar 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ELY-1996] SSLContext to support delegation to alternate instances based on peer information. #1488

[ELY-1996] SSLContext to support delegation to alternate instances based on peer information. #1488

Skyllarr commented Feb 15, 2021

Skyllarr Feb 15, 2021

darranl Feb 17, 2021

fjuma Feb 17, 2021

wildfly-ci commented Feb 15, 2021

wildfly-ci commented Feb 15, 2021

wildfly-ci commented Feb 16, 2021

wildfly-ci commented Feb 16, 2021

fjuma commented Feb 16, 2021

Skyllarr commented Feb 17, 2021

fjuma Mar 2, 2021

Skyllarr Mar 3, 2021

wildfly-ci commented Mar 3, 2021

wildfly-ci commented Mar 3, 2021

fjuma Mar 4, 2021

Skyllarr Mar 5, 2021

fjuma Mar 5, 2021

fjuma May 31, 2021

[ELY-1996] SSLContext to support delegation to alternate instances based on peer information. #1488

[ELY-1996] SSLContext to support delegation to alternate instances based on peer information. #1488

Conversation

Skyllarr commented Feb 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented Feb 15, 2021

wildfly-ci commented Feb 15, 2021

wildfly-ci commented Feb 16, 2021

wildfly-ci commented Feb 16, 2021

fjuma commented Feb 16, 2021

Skyllarr commented Feb 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented Mar 3, 2021

wildfly-ci commented Mar 3, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment