Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2053] key-store-masked-password needs the elytron provider to be manually registered #1470

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Dec 9, 2020

Issue: https://issues.redhat.com/browse/ELY-2053

The option key-store-masked-password needed to manually add the elytron provider when the wildfly-config.xml was used in a standalone app. The change just passes the providersSupplier parameter as in all the rest of the calls. It also modifies the related test to not include the provider as before.

PR sent to 1.x if if it is needed in more branches just let me now.

Thanks!

@wildfly-ci
Copy link

Hello, rmartinc. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@rmartinc
Copy link
Contributor Author

@fjuma @darranl Remember this PR, it's a minor issue but better if it's fixed. 😄

@fjuma
Copy link
Contributor

fjuma commented Jan 20, 2021

/ok-to-test

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmartinc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants