[ELY-2696] Update 3 tests in PrincipalMappingSuiteChild to call a com…

…mon method in order to remove duplicated code
wildfly-security · Oct 17, 2023 · 89dbbd1 · 89dbbd1
1 parent ba17f4c
commit 89dbbd1
Showing 1 changed file with 8 additions and 28 deletions.
diff --git a/tests/base/src/test/java/org/wildfly/security/ldap/PrincipalMappingSuiteChild.java b/tests/base/src/test/java/org/wildfly/security/ldap/PrincipalMappingSuiteChild.java
@@ -35,8 +35,7 @@
  */
 public class PrincipalMappingSuiteChild {
 
-    @Test
-    public void testSimpleToDn() throws RealmUnavailableException {
+    private void testSimpleCommon() throws RealmUnavailableException {
         SecurityRealm realm = LdapSecurityRealmBuilder.builder()
                 .setDirContextSupplier(LdapTestSuite.dirContextFactory.create())
                 .identityMapping()
@@ -52,6 +51,11 @@ public void testSimpleToDn() throws RealmUnavailableException {
         assertFalse("Exists", identity.exists());
     }
 
+    @Test
+    public void testSimpleToDn() throws RealmUnavailableException {
+        testSimpleCommon();
+    }
+
     @Test
     public void testDnToSimple() throws RealmUnavailableException {
         SecurityRealm realm = LdapSecurityRealmBuilder.builder()
@@ -70,36 +74,12 @@ public void testDnToSimple() throws RealmUnavailableException {
 
     @Test
     public void testSimpleToSimpleValidate() throws RealmUnavailableException {
-        SecurityRealm realm = LdapSecurityRealmBuilder.builder()
-                .setDirContextSupplier(LdapTestSuite.dirContextFactory.create())
-                .identityMapping()
-                    .setSearchDn("dc=elytron,dc=wildfly,dc=org")
-                    .setRdnIdentifier("uid")
-                    .build()
-                .build();
-
-        RealmIdentity identity = realm.getRealmIdentity(new NamePrincipal("PlainUser"));
-        assertTrue("Exists", identity.exists());
-
-        identity = realm.getRealmIdentity(new NamePrincipal("nobody"));
-        assertFalse("Exists", identity.exists());
+        testSimpleCommon();
     }
 
     @Test
     public void testSimpleToSimpleReload() throws RealmUnavailableException {
-        SecurityRealm realm = LdapSecurityRealmBuilder.builder()
-                .setDirContextSupplier(LdapTestSuite.dirContextFactory.create())
-                .identityMapping()
-                    .setSearchDn("dc=elytron,dc=wildfly,dc=org")
-                    .setRdnIdentifier("uid")
-                    .build()
-                .build();
-
-        RealmIdentity identity = realm.getRealmIdentity(new NamePrincipal("PlainUser"));
-        assertTrue("Exists", identity.exists());
-
-        identity = realm.getRealmIdentity(new NamePrincipal("nobody"));
-        assertFalse("Exists", identity.exists());
+        testSimpleCommon();
     }
 
     @Test